codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.70%. Comparing base (
62825c1) to head (49256ba). Report is 1 commits behind head on dev.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #510 +/- ## ========================================== + Coverage 73.67% 73.70% +0.02% ========================================== Files 15 15 Lines 3210 3213 +3 ========================================== + Hits 2365 2368 +3 Misses 845 845 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/510/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/510/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `73.70% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
dont emit "ovos.utterance.handled" by pretending to be a intent_type, be explicit about handling this message
the non-intent pipeline components should not need to lie or know about this message type, now they only return True if that's the end of the utterance handling instead of a "magic string"