OpenVoiceOS / ovos-core

OpenVoiceOS Core, the FOSS Artificial Intelligence platform.
https://openvoiceos.org
Apache License 2.0
122 stars 17 forks source link

fix/killable_converse #523

Closed JarbasAl closed 1 month ago

JarbasAl commented 1 month ago

similarly to fallback, kill converse handlers forcibly if they time out

companion to https://github.com/OpenVoiceOS/OVOS-workshop/pull/221

issue reported in chat https://matrix.to/#/!cmlvncOxnMnkkybXNy:matrix.org/$YIKe7VJn_ZmJhOFSRLSba4tmKQbySy5OVicLpoLeXKo?via=matrix.org&via=kanp.ai&via=matrix.hivepost.nl

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.72%. Comparing base (3adf5e9) to head (fd33862). Report is 3 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #523 +/- ## ========================================== + Coverage 75.57% 75.72% +0.14% ========================================== Files 15 15 Lines 3042 3044 +2 ========================================== + Hits 2299 2305 +6 + Misses 743 739 -4 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/523/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/523/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `75.72% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.