codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
Project coverage is 75.67%. Comparing base (
3adf5e9) to head (82bf8c2). Report is 1 commits behind head on dev.
| Files | Patch % | Lines |
|---|---|---|
| ovos_core/intent_services/ocp_service.py | 90.47% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #524 +/- ## ========================================== + Coverage 75.57% 75.67% +0.09% ========================================== Files 15 15 Lines 3042 3042 ========================================== + Hits 2299 2302 +3 + Misses 743 740 -3 ``` | [Flag](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/524/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OpenVoiceOS/ovos-core/pull/524/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS) | `75.67% <90.47%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenVoiceOS#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
pass kwarg for source message, in some cases dig_for_message returns None
companion to https://github.com/OpenVoiceOS/ovos-bus-client/pull/103
unsure when it happens, but issues noticed with hivemind
to test ask to play something from a voice sat, without this PR the destination might be missing and playback happens in core, not in voice sat. sometimes it works so i am not sure what causes dig_for_message to occasionally miss the source message