OpenVoiceOS / ovos-date-parser

0 stars 2 forks source link

Inconsistent Dutch number formatting in Dutch test cases #27

Open coderabbitai[bot] opened 3 weeks ago

coderabbitai[bot] commented 3 weeks ago

There are inconsistencies in the Dutch number formatting in the test cases located at ovos_date_parser/res/nl-nl/date_time_test.json. This issue was identified in PR #1: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1

Discussion: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1#discussion_r1831942323

The codebase shows that the correct Dutch format for compound numbers (21-99) is without spaces, joining the numbers with "en". This is evidenced by date_time.json which uses the correct format: "eenentwintig", "tweeentwintig", etc.

The test cases need to be updated for consistency:

The suggestion about missing edge cases (year 0, negative years, large years) remains valid, but the primary formatting inconsistency needs to be addressed first.

Requester: @JarbasAl.

j1nx commented 2 weeks ago

You write the numbers without the spaces however it could well be that the TTS pronouchiation sounds better with spaces.

need to feed these into some TTS providers to investigate if I am right.