search

OpenVoiceOS / ovos-docker

Open Voice OS container images and docker-compose.yml files for x86_64 and aarch64 CPU architectures.
https://openvoiceos.github.io/ovos-docker/
Apache License 2.0
41 stars 13 forks source link

move env to env.example to avoid overriding it #27

Closed denics closed 1 year ago

goldyfruit commented 1 year ago

Please update the README to reflect the change, like "Before running docker compose command make sure to copy compose/.env.example to compose/.env".

Something like that.

goldyfruit commented 1 year ago

Could you please explain a bit more about the reason of this change because this change will potentially break the working "out of the box" as the user has to copy/create a .env file and if he doesn't then weird behaviour could happen during the stack creation.

denics commented 1 year ago

Could you please explain a bit more about the reason of this change because this change will potentially break the working "out of the box" as the user has to copy/create a .env file and if he doesn't then weird behaviour could happen during the stack creation.

You are right, I should have added the one line to the documentation. I just think that it is more user friendly for not experienced users to have to do a step more from your cut&paste working instructions, cp .env.example .env, than to manage merge issues with git every time the .env file is modified (i.e. I use a different subfolder for my config files).

goldyfruit commented 1 year ago

You are right, I should have added the one line to the documentation. I just think that it is more user friendly for not experienced users to have to do a step more from your cut&paste working instructions, cp .env.example .env, than to manage merge issues with git every time the .env file is modified

Yeah, this is a valid point. Then I guess, .env-raspberrypi file should be as well moved as example.

Please update the README.md and we are good to go! :+1:

goldyfruit commented 1 year ago

Thanks @denics :+1: