OpenVoiceOS / ovos-installer

Open Voice OS and/or HiveMind installer using Ansible with an intuitive and easy Text-based User Interface
https://www.openvoiceos.org
79 stars 21 forks source link

Enable 'Fake barge in' by default? #169

Closed timonvanhasselt closed 1 month ago

timonvanhasselt commented 1 month ago

Based on a DM with @JarbasAl, maybe a consideration to enable "fake barge in" by default in the user mycroft.conf for RPi users and/or other setups with less quality microphones.

Background: I had a problem where my utterance was not picked up because of the audio/speech that was already playing (setup: PC with jabra speaker). Fake barge in solved that issue for me. I think it's a better UX with fake barge in enabled.

  "listener": {
     "fake_barge_in": true
goldyfruit commented 1 month ago

Maybe this should be set by default in ovos-config rather than in the ovos-installer?

JarbasAl commented 1 month ago

i wouldnt want this by default other than in a rpi, and when mk2 drivers work there should be an exception as the sj201 does noise cancellation at hardware level

in more powerful systems a better experience would be to use something like https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#module-echo-cancel or RNNoise

i will give it some more thinking, but until then i think the installer should do it for rpi boards

goldyfruit commented 1 month ago

mk2 drivers work there should be an exception as the sj201 does noise cancellation at hardware level

This doesn't work since kernel 5.x.

https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#module-echo-cancel

PulseAudio is replaced by PipeWire in most of the distributions. PipeWire is only installed and configured by the installer on Raspberry Pi boards as on laptops/PCs the user might have custom settings already configured.

JarbasAl commented 1 month ago

wasnt suggesting the installer handle that, just showing what kind of alternatives i think make sense to fake barge in

i assume pipewire has an equivalent plugin?

goldyfruit commented 1 month ago

i assume pipewire has an equivalent plugin?

Not that I'm aware off :disappointed: