Closed suvanbanerjee closed 1 month ago
suvanbanerjee
commented
1 month ago @goldyfruit will this file structure work, I will ask user for autoconfig questions and then run the command accordingly, to tackle the region issue we can find region using their ip to detect their country so if someone chooses English in Australia then its en-au, en-> from his language choice au-> from his country ip
JarbasAl
commented
1 month ago @goldyfruit will this file structure work, I will ask user for autoconfig questions and then run the command accordingly, to tackle the region issue we can find region using their ip to detect their country so if someone chooses English in Australia then its en-au, en-> from his language choice au-> from his country ip
i wouldnt worry about this for now, as the translations currently are all for en-us , setting a different code might just cause issues with no benefit
only portuguese currently differentiates between pt-br and pt-pt, no other language supports different dialect lang codes (yet)
goldyfruit
commented
1 month ago I would not prompt any questions about the auto configuration. By default if French is selected then the assistant should be configured to in French, etc...
About the male or female voice, this question should be handle by the core team as its part of the OVOS's persona.
@JarbasAl @j1nx Do we want to have a male or female persona?
JarbasAl
commented
1 month ago team
If not prompting user, keep it male
suvanbanerjee
commented
1 month ago If not prompting user, keep it male
I guess the standard for voice assistant is female ?
JarbasAl
commented
1 month ago If not prompting user, keep it male
I guess the standard for voice assistant is female ?
historically we have used the male voice from alan pope, which goes well with "hey mycroft". let's keep it that way
besides, its a good differentiation factor in comparison with other voice assistants
goldyfruit
commented
1 month ago @suvanbanerjee I just pushed a commit, please have a look.
coderabbitai[bot]
commented
1 month ago The pull request introduces new tasks in Ansible playbooks for auto-configuration of Speech-to-Text (STT) and Text-to-Speech (TTS) using the ovos-config command. This feature is conditionally executed based on the user's profile, specifically when it is not set to "server". Minor formatting adjustments were made to enhance the readability of existing tasks without altering their functionality.
| File Path | Change Summary |
|---|---|
ansible/roles/ovos_installer/tasks/docker/composer.yml |
Added task for running ovos-config for STT and TTS auto-configuration; minor formatting adjustments made. |
ansible/roles/ovos_installer/tasks/virtualenv/venv.yml |
Introduced task for running ovos-config for STT and TTS auto-configuration; updated file ownership command for performance. |
| Objective | Addressed | Explanation |
|---|---|---|
Use ovos-config for STT and TTS auto-configuration (#[157]) |
✅ |
🐇 In the garden where the code does play,
New tasks bloom bright, guiding the way.
Withovos-config, we sing and cheer,
Auto-configured voices, loud and clear!
TTS and STT, together they thrive,
In the world of speech, we come alive! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
goldyfruit
commented
1 month ago mycroft.conf generated by the ovos-config seems off.
{
"log_level": "INFO",
"play_wav_cmdline": "pw-play %1",
"play_mp3_cmdline": "pw-play %1",
"lang": "ca-ES",
"listener": {
"remove_silence": true,
"VAD": {
"module": "ovos-vad-plugin-silero"
},
"instant_listen": true
},
"skills": {
"installer": {
"allow_pip": true,
"allow_alphas": true
}
},
"websocket": {
"max_msg_size": 25
},
"PHAL": {
"ovos-PHAL-plugin-wifi-setup": {
"module": "ovos-PHAL-plugin-wifi-setup",
"lang": "ca-ES",
"secondary_langs": [],
"system_unit": "metric",
"temperature_unit": "celsius",
"windspeed_unit": "km/h",
"precipitation_unit": "mm",
"time_format": "full",
"spoken_time_format": "half",
"date_format": "DMY",
"opt_in": false,
"confirm_listening": true,
"ready_settings": [
"skills"
],
"ignore_logs": [
"enclosure.mouth.viseme",
"enclosure.mouth.display"
],
"enable_old_audioservice": true,
"debug": false,
"log_level": "INFO",
"play_wav_cmdline": "pw-play %1",
"play_mp3_cmdline": "pw-play %1",
"first_boot": false
}
},
"tts": {
"ovos-tts-plugin-server": {
"host": [
"https://tts.smartgic.io/matxa",
"https://matxa.ziggyai.online"
],
"voice": "central/grau"
},
"module": "ovos-tts-plugin-server"
},
"stt": {
"ovos-stt-plugin-server": {
"url": [
"https://stt.smartgic.io/citrinet",
"https://citrinetstt.ziggyai.online"
]
},
"module": "ovos-stt-plugin-server",
"fallback_module": ""
},
"system_unit": "metric",
"temperature_unit": "celsius",
"windspeed_unit": "km/h",
"precipitation_unit": "mm",
"time_format": "full",
"spoken_time_format": "half",
"date_format": "DMY"
}
mycroft.confgenerated by theovos-configseems off.{ "log_level": "INFO", "play_wav_cmdline": "pw-play %1", "play_mp3_cmdline": "pw-play %1", "lang": "ca-ES", "listener": { "remove_silence": true, "VAD": { "module": "ovos-vad-plugin-silero" }, "instant_listen": true }, "skills": { "installer": { "allow_pip": true, "allow_alphas": true } }, "websocket": { "max_msg_size": 25 }, "PHAL": { "ovos-PHAL-plugin-wifi-setup": { "module": "ovos-PHAL-plugin-wifi-setup", "lang": "ca-ES", "secondary_langs": [], "system_unit": "metric", "temperature_unit": "celsius", "windspeed_unit": "km/h", "precipitation_unit": "mm", "time_format": "full", "spoken_time_format": "half", "date_format": "DMY", "opt_in": false, "confirm_listening": true, "ready_settings": [ "skills" ], "ignore_logs": [ "enclosure.mouth.viseme", "enclosure.mouth.display" ], "enable_old_audioservice": true, "debug": false, "log_level": "INFO", "play_wav_cmdline": "pw-play %1", "play_mp3_cmdline": "pw-play %1", "first_boot": false } }, "tts": { "ovos-tts-plugin-server": { "host": [ "https://tts.smartgic.io/matxa", "https://matxa.ziggyai.online" ], "voice": "central/grau" }, "module": "ovos-tts-plugin-server" }, "stt": { "ovos-stt-plugin-server": { "url": [ "https://stt.smartgic.io/citrinet", "https://citrinetstt.ziggyai.online" ] }, "module": "ovos-stt-plugin-server", "fallback_module": "" }, "system_unit": "metric", "temperature_unit": "celsius", "windspeed_unit": "km/h", "precipitation_unit": "mm", "time_format": "full", "spoken_time_format": "half", "date_format": "DMY" }
I removed the ovos-PHAL-plugin-wifi-setup package which is the culprit.
suvanbanerjee
commented
1 month ago thanks @goldyfruit for the pr's it made my job super easy 😅, i think this pr is ready to review and push, if there are any more changes please require do tell me
goldyfruit
commented
1 month ago thanks @goldyfruit for the pr's it made my job super easy 😅
I mostly did it as you can learn from it for the next time.
goldyfruit
commented
1 month ago @suvanbanerjee have you tried this PR?
Closes #157
Summary by CodeRabbit
New Features
Bug Fixes