Closed goldyfruit closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The changes involve modifications to the extra-skills-requirements.txt.j2
template file within the Ansible role for the OVOS installer. Specifically, a conditional block that included the ovos-skill-easter-eggs
skill from a GitHub repository has been commented out. This change disables the inclusion of this skill unless the ovos_installer_profile
is set to "server". Other entries for ovos-core
and ovos-skill-icanhazdadjokes
remain unchanged.
File Path | Change Summary |
---|---|
ansible/roles/ovos_installer/templates/virtualenv/extra-skills-requirements.txt.j2 | Commented out the inclusion of ovos-skill-easter-eggs skill based on ovos_installer_profile . |
extra-skills-requirements.txt.j2
template file, specifically adding new skills, which is directly related to the modifications made in the main PR that comments out a skill inclusion.🐰 In the garden where skills do bloom,
A skill was hushed, lost in the gloom.
With a simple comment, it took a rest,
While others still shine, they are the best.
Hop along, dear friends, to a skillful delight,
For every change brings a new path to light! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Commenting the skill installation until this https://github.com/OpenVoiceOS/ovos-skill-easter-eggs/pull/47 got merged as it downgrade
ovos-core
to 2.3.0 which doesn't contain the fallback match https://github.com/OpenVoiceOS/ovos-core/pull/572Summary by CodeRabbit
Bug Fixes
ovos-skill-easter-eggs
skill when the profile is not set to "server", preventing potential issues.Chores