search

OpenVoiceOS / ovos-installer

Open Voice OS and/or HiveMind installer using Ansible with an intuitive and easy Text-based User Interface
https://www.openvoiceos.org
48 stars 12 forks source link

feat/arch_support #59

Closed JarbasAl closed 4 months ago

JarbasAl commented 4 months ago

still untested, need to verify all package names!

closes #58

JarbasAl commented 4 months ago

image image

tested with venv / containers both install and uninstall with all combos of hivemind/ovos/gui

only didnt test voice sat

goldyfruit commented 4 months ago
  • I would like to be able to pick where my venv is

Many people doesn't know what a venv is, this is prone to user error.

  • It moves my existing ~/.config/mycroft/mycroft.conf instead of using it, or at least asking to use it

We discussed this point on Matrix, if the user change the mcyroft.conf then the installer backups the file (in ~/.config/mycroft/) but restore the original to avoid user's breaking change.

  • it also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something

99% of the user will not have existing ovos-*.service in ~/.config/systemd/user/ directory. The installer will not use existing files as they might be totally different of what the installer is expecting.

builderjer commented 4 months ago

I agree with these, especially the venv. But if there are existing files, the user must know they are there, so there should at least be a prompt or verification that they are getting moved/overwritten

JarbasAl commented 4 months ago
  • t also wrote over my existing systemd files and I don't like that. Either use them, or ask to overwrite, or something

IMHO this is intended, if its doing a reinstall on top of an existing one most likely something is broken or outdated, and if the user then runs this installer on top then that is what gets the user back into a working state.

people who made their own service files either know what they are doing and dont want to use installer at all, or are noobs who followed some script or advice they didnt understand and now dont have a working ovos install

goldyfruit commented 4 months ago

I agree with these, especially the venv. But if there are existing files, the user must know they are there, so there should at least be a prompt or verification that they are getting moved/overwritten

Just added a backup option, if files exist and there is a change in it, then the file will be backup.

https://github.com/OpenVoiceOS/ovos-installer/commit/0505c2ed01e26d0d88f9cbda86f93b89c6a09bf6