search

OpenVoiceOS / ovos-installer

Open Voice OS and/or HiveMind installer using Ansible with an intuitive and easy Text-based User Interface
https://www.openvoiceos.org
48 stars 12 forks source link

added back button #66

Closed suvanbanerjee closed 2 months ago

suvanbanerjee commented 2 months ago

added back button in first three pages. i tested it and is working i just want to know is doing it this way works ? or i am missing something. Fixes #64

suvanbanerjee commented 2 months ago

@goldyfruit please check

goldyfruit commented 2 months ago

Just tested the PR, and I don't think this will be the best approach as I'm pretty sure users will not see the Back button (which is not a button indeed)

image

Maybe we should just replace the Cancel button by the Back button.

@mikejgray @JarbasAl what do you think?

mikejgray commented 2 months ago

Just tested the PR, and I don't think this will be the best approach as I'm pretty sure users will not see the Back button (which is not a button indeed)

image

Maybe we should just replace the Cancel button by the Back button.

@mikejgray @JarbasAl what do you think?

I agree, this is confusing because it looks like Back is a branch.

If you replace Cancel with Back, can you still close out the TUI with Control+C?

suvanbanerjee commented 2 months ago

@goldyfruit
I will replace the Cancle with Back. @mikejgray Ctrl+C will not close TUI. Ctrl+C now also don't closes the TUI. We have to use ESC to quit the TUI but ESC to quit dont works on Fedora/CentOS (https://superuser.com/questions/966589/esc-key-does-not-work-for-whiptail-on-centos-fedora) I think is due to limitations of whiptail one solution should be moving to dialogs but that will be a major code refactor.

suvanbanerjee commented 2 months ago

@goldyfruit i have change Cancel button to Back in first 3 panels. If it looks good then i will also update the rest of a pages. Please allow me a couple of days because after profiles there are multiple paths so it will take time to add back buttons on those pages

image

goldyfruit commented 2 months ago

Yeah looks better. :+1:

suvanbanerjee commented 2 months ago

@goldyfruit Please check I have replaced the cancel button by back button in all pages. I have to do some major changes in satellite\main.sh please test it extensively

suvanbanerjee commented 2 months ago

CANCEL_BUTTON can be removed from the locale files.

I think we should not because in future there is a chance we might need a cancel button. However, if you prefer, I will remove it.

goldyfruit commented 2 months ago

CANCEL_BUTTON can be removed from the locale files.

I think we should not because in future there is a chance we might need a cancel button. However, if you prefer, I will remove it.

I would remove it since we saw that two buttons is the only "non-confusing" option.

goldyfruit commented 2 months ago

Good job @suvanbanerjee :+1: :tada:

suvanbanerjee commented 2 months ago

Thanks @goldyfruit for your mentorship. many more PR to go 🎉