OpenVoiceOS / ovos-installer

Open Voice OS and/or HiveMind installer using Ansible with an intuitive and easy Text-based User Interface
https://www.openvoiceos.org
48 stars 12 forks source link

[FIX] Installer allowing invalid config.yaml files #77

Closed suvanbanerjee closed 2 months ago

suvanbanerjee commented 2 months ago
uninstall: false
method: xyz
channel: abc
profile: ovos
features:
  skills: true
  gui: true
rapsberry_pi_tuning: true
share_telemetry: true

is an invalid config.yaml file but still is considered valid and installs ovos.

Fix: used conditional statements to validate each options correctness. Closes: #72

goldyfruit commented 2 months ago

@suvanbanerjee Thanks.

suvanbanerjee commented 2 months ago

Did you test it?

I tested it locally by running it not usings the BATS tests. and it works by saying seceniro not supported image log https://sprunge.us/ZvSMFd

What is the output when it breaks?

image this is the output when using method: xyz and channel: abc in the current version

suvanbanerjee commented 2 months ago

@goldyfruit I think the failed bats test in #73 is also due to the invalid config.yaml file. but unable to confirm as i am not aware how to run BATS test locally

goldyfruit commented 2 months ago

@goldyfruit I think the failed bats test in #73 is also due to the invalid config.yaml file. but unable to confirm as i am not aware how to run BATS test locally

Just to make sure, your file is named scenario.yaml and not config.yaml, right?

suvanbanerjee commented 2 months ago

@goldyfruit I think the failed bats test in #73 is also due to the invalid config.yaml file. but unable to confirm as i am not aware how to run BATS test locally

Just to make sure, your file is named scenario.yaml and not config.yaml, right?

my bad it's scenario.yaml only. 😅

https://pastebin.com/wV0AkayA here is the full log for the output when using method: xyz and channel: abc in the current version

goldyfruit commented 2 months ago

I'm gonna test it later today. :+1:

suvanbanerjee commented 2 months ago

I'm gonna test it later today. 👍

Just tested it using github actions and it is still failing the bats test.