search

OpenVoiceOS / ovos-installer

Open Voice OS and/or HiveMind installer using Ansible with an intuitive and easy Text-based User Interface
https://www.openvoiceos.org
48 stars 12 forks source link

regarding Arch #91

Closed Shadowphoenix closed 1 week ago

Shadowphoenix commented 1 month ago

ik Arch is currently unsupported however i think i have found a way to still make it work.

https://aur.archlinux.org/packages/python311 can be used to get the python-venv up and running so i would find it reasonable to at least mention this in the Readme, however with the Caviart of saying that running anything from the AUR means you are on your own.

goldyfruit commented 1 month ago

@Shadowphoenix Arch is a supported OS.

https://github.com/OpenVoiceOS/ovos-installer/blob/main/utils/common.sh#L235

JarbasAl commented 1 month ago

arch is now on python 3.12, i believe that is the problem here

Shadowphoenix commented 1 month ago

@Shadowphoenix Arch is a supported OS.

https://github.com/OpenVoiceOS/ovos-installer/blob/main/utils/common.sh#L235

yeah i seem to have had a bit of an Aneurysm skimming the Readme Lol. Yeah, Installer doesnt work with Python 3.12 because the script searches for 3.11 specificall. installing Python 3.11 for example via that AUR-Package is a workaround for the time being

goldyfruit commented 1 month ago

I think it might be time to switch to Python 3.12, I gonna have to run more tests but so far so good.

goldyfruit commented 1 week ago

@Shadowphoenix do you mind to try this PR https://github.com/OpenVoiceOS/ovos-installer/pull/101?

Shadowphoenix commented 1 week ago

@Shadowphoenix do you mind to try this PR #101?

will do tmrw.

Shadowphoenix commented 1 week ago

On another note i suggest rewriting the Readme a little.

Remember how i stumbled over the | Arch | N/A | you have written there?

Usually when i encounter N/A, it means "not available". This suggests that something is not supported in any way shape or form which was what lead me to think i cant run this on Arch properly.

https://en.wikipedia.org/wiki/N/A

While technically it is correct as there is no one specific version of Arch you need to run this, this is a bit misleading. Since Arch, Manjaro and the other rolling releases dont have any specific "versions" that could be supported because they are rolling releases, why not replace the "not available" with "supported" or a simple "Yes"?

goldyfruit commented 1 week ago

N/A works as well for Not Applicable but I will have a look on how to improve it.

goldyfruit commented 1 week ago

Change got merged, please re-open if needed.

goldyfruit commented 1 week ago

https://github.com/OpenVoiceOS/ovos-installer/commit/3c1a3d515eb6ab2ec3e88fb3bdc7e1f453e5551b