OpenVoiceOS / ovos-lingua-franca

Mycroft's multilingual text parsing and formatting library
Apache License 2.0
7 stars 7 forks source link

Localized language code extraction #24

Open NeonDaniel opened 2 years ago

NeonDaniel commented 2 years ago

The extract_langcode method only extracts localized language codes for "en-us" and "pt-br". langs.json probably needs to be extended to parse more variants (i.e. en-uk, en-au, fr-ca, es-mx...). Or maybe a separate mapping of country names to codes to parse separately? It may be more generically useful to be able to parse locales separate from languages for things like default units, currencies, better location parsing

NeonDaniel commented 2 years ago

From Matrix discussion:

extract_langcode("American English") = 'en'
extract_countrycode("American English") = "us"

"American English" or "Inglês Americano" both resolve to US, skills for sure wont have a list for every country in every language

JarbasAl commented 2 years ago

Considerations: