OpenVoiceOS / ovos-ocp-audio-plugin

Apache License 2.0
4 stars 6 forks source link

OCP skills supporting PlaybackType.SKILL cannot be played when there is no GUI #92

Closed Ramblurr closed 1 year ago

Ramblurr commented 1 year ago

Problem description

Skills that support PlaybackType.SKILL (for example my Roon controller skill that controls smart speakers unware of OVOS) cannot have their OCP search results played when there is no GUI.

My expectation is that my OCP skill should be able to handle search events and have those results handled (passed to my skill) even if there is no GUI.

Diagnosis

Problem code:

https://github.com/OpenVoiceOS/ovos-ocp-audio-plugin/blob/b26f4fadd841221b92764a4b2489d533960f5658/ovos_plugin_common_play/ocp/__init__.py#L377-L381

I believe that line 381 should be if r["playback"] in [PlaybackType.AUDIO, PlaybackType,SKILL]