search

OpenVoiceOS / ovos-personal-backend

personal backend - self-hosted backend to manage multiple OVOS devices
Apache License 2.0
78 stars 26 forks source link

Bug/default ww #45

Closed builderjer closed 1 year ago

builderjer commented 1 year ago

Changed default wakewords to use precise instead of pocketsphinx. Precise-lite is installed by default on the buildroot image, the manjaro image, and neon. It is much more "precise" than pocketsphinx

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@d4e3247). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head e1e1c56 differs from pull request most recent head bdb7a61. Consider uploading reports for the commit bdb7a61 to get more accurate results

@@          Coverage Diff          @@
##             dev     #45   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      22           
  Lines          ?    1509           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    1509           
  Partials       ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JarbasAl commented 1 year ago

I have mixed feelings here, what we really need is a mechanism for devices to report what plugins are installed

this is potentially breaking for vanilla mycroft usage, but i will accept the PR since it already required the ovos pocketsphinx plugin anyway

builderjer commented 1 year ago

I agree that it should look for plug-ins, but don't the images come with at least one ww engine that is common to all?

builderjer commented 1 year ago

Or I could add precise models too instead of precise-lite? Isn't that what mycroft ships with?

JarbasAl commented 1 year ago

I agree that it should look for plug-ins, but don't the images come with at least one ww engine that is common to all?

this is a standalone project that works with regular mycroft and is not exclusive to our OVOS images, so we cant assume any plugin is installed

mycroft itself lacks a mechanism for reporting installed plugins and removed the ww selection feature from selene with the mk2 release, so i think its fair to consider this a personal backend exclusive feature for now.

In the future I'll look into improving this, for now lets merge this :+1: