search

OpenVoiceOS / ovos-plugin-manager

plugin manager for OpenVoiceOS , STT/TTS/Wakewords that can be used anywhere
Apache License 2.0
12 stars 11 forks source link

abstractmethod decorator breaks OCP 0.0.6 compat. #229

Closed NeonDaniel closed 4 months ago

NeonDaniel commented 4 months ago

This refactor breaks compat with OCP 0.0.6 and OCP 0.0.7a2 includes a dependency on ovos-utils 0.1.0. This should probably be updated for backwards-compat. so it may be included with ovos-core 0.0.8 which will not depend on ovos-utils 0.1.0

2024-05-17 15:24:03.671 - audio - ovos_audio.audio:load_services:128 - INFO - Found audio service plugin: ovos_common_play
2024-05-17 15:24:03.684 - audio - ovos_plugin_manager.audio:setup_audio_service:70 - ERROR - Failed to load audio service. TypeError("Can't instantiate abstract class OCPAudioBackend with abstract method playback_time")

_Originally posted by @NeonDaniel in https://github.com/OpenVoiceOS/ovos-plugin-manager/pull/226#discussion_r1605592732_

JarbasAl commented 4 months ago

fixed by #230