search

OpenVoiceOS / ovos-skill-application-launcher

launch applications by voice
Apache License 2.0
2 stars 2 forks source link

Ask confirmation if multiple processes with same name exists #17

Open goldyfruit opened 1 month ago

goldyfruit commented 1 month ago

When asking to close an application, the skill automatically closes all the processes of the same name which can be an issue.

In my case it closed all my Kitty terminals.

Having a confirmation would be nice.

JarbasAl commented 1 month ago

this is now partially configurable, if multiple processes (with different PIDs) match it will only close the most recent one, to kill all (old behaviour) there is a setting

in X systems preference is given to close windows instead of terminating processes, which gives more granularity (eg, multiple firefox windows count as a single process)

JarbasAl commented 1 month ago

semi related, https://github.com/OpenVoiceOS/ovos-skill-application-launcher/pull/25 adds prompts when opening an application that is already open