search

OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

[FEAT] Convert to OCP #11

Closed mikejgray closed 1 year ago

mikejgray commented 1 year ago

Objective

For example when asking for do you like portal, the sound is quiet long to play and it would be nice to be able to stop the playing via the stop intent.

Initial Implementation Requirements

I think the sound should be handled by Common Play and not by core it-self.

Other Considerations

No response

https://github.com/mikejgray/skill_easter_eggs/issues/1

mikejgray commented 1 year ago

Spoke with Jarbas about this and the play_audio() method in recent versions of OVOS should take care of this automatically. Failure to stop would be a bug on that side. Converting the entire skill to an OCP skill would break other functionality.

He did say he'll be implementing better stop functionality in a future version, so this should improve.