OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

feat: grandma mode #13

Closed mikejgray closed 1 year ago

mikejgray commented 1 year ago

Closes #9

Adds "grandma mode" to tone down some of the more aggressive movie sounds. Grandma mode is enabled by default, mostly so that the user has the experience of making a Doom reference to turn it off.

mikejgray commented 1 year ago

German resources and tests are English, these should probably be translated

I wanted to get an opinion from some multilingual folks about the translation. These intents are direct lifts from Doom difficulty settings, so I wasn't sure how applicable a translation would be. I've seen other skills where certain intents were not translated but I don't know the intention behind keeping it in English.

NeonDaniel commented 1 year ago

I wanted to get an opinion from some multilingual folks about the translation. These intents are direct lifts from Doom difficulty settings, so I wasn't sure how applicable a translation would be. I've seen other skills where certain intents were not translated but I don't know the intention behind keeping it in English.

I also don't have a good answer for adding untranslated resources vs omitting them.. @JarbasAl suggested above omitting translations; I think that makes sense unless a German speaker (@emphasize ?) has any input.

emphasize commented 1 year ago

can't speak for other langs than german, but we usually have good localizations, sometimes corny but i would guess the most folks don't know/remember the original quotes.

(On a sidenote Bud Spencer/Terence Hill quotes are pretty popular here. The translators gave them a special humoristic flavor not found in other langs)

Secondly, if you feed english words to non-english TTS you get a localized version of that english word. In case of Arnie that might be a funny quirk (in german), but generally sounds off. I used "backend" in the skill setup translations and everytime i hear it angers me. instead of [ˌbæˈkɛnd] we get [ˈbakn̩t]

Doom original is on GamePass, so i can check

(EDIT: But like Jarbas said, IF intent translations, we also have to capture the translated media)

mikejgray commented 1 year ago

can't speak for other langs than german, but we usually have good localizations, sometimes corny but i would guess the most folks don't know/remember the original quotes.

(On a sidenote Bud Spencer/Terence Hill quotes are pretty popular here. The translators gave them a special humoristic flavor not found in other langs)

Secondly, if you feed english words to non-english TTS you get a localized version of that english word. In case of Arnie that might be a funny quirk (in german), but generally sounds off. I used "backend" in the skill setup translations and everytime i hear it angers me. instead of [ˌbæˈkɛnd] we get [ˈbakn̩t]

Doom original is on GamePass, so i can check

(EDIT: But like Jarbas said, IF intent translations, we also have to capture the translated media)

Capturing the translation media would be a non-trivial task...leaning towards keeping it English to avoid the issues you mentioned here. Thoughts?

EDIT: I'd still like to do a full localization at some point, so it'd be a separate effort from this particular feature

mikejgray commented 1 year ago

Opened an issue to handle full localization. For now we'll keep these intents strictly in English. Do we need to remove the new ones so we don't run into the localized version of the word problem @emphasize mentioned?

JarbasAl commented 1 year ago

i would remove any resource files not for english for now

mikejgray commented 1 year ago

i would remove any resource files not for english for now

Done. Thanks for all the feedback and conversation, everyone. I think this is ready for review again.