OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

May I have some more sir? #28

Closed builderjer closed 6 months ago

builderjer commented 8 months ago

There are several other skills floating around similar to Duke Nukem and I think it would be fun to include them.

https://github.com/Quinn2017/Skill-Bill-and-Teds https://github.com/KathyReid/skill-malibu-stacy https://github.com/aussieW/skill-farting https://github.com/EuripideH/skill-bouddha https://github.com/aussieW/skill-confucius-say

I am sure there are a few more, but here is a start.

JarbasAl commented 8 months ago

https://github.com/JarbasSkills/skill-confucius-quotes i got this one updated

builderjer commented 7 months ago

Just found another https://github.com/JarbasSkills/skill-pickup-lines

mikejgray commented 7 months ago

Will add these in, since they're pretty small:

https://github.com/Quinn2017/Skill-Bill-and-Teds https://github.com/KathyReid/skill-malibu-stacy

These should probably be their own thing: https://github.com/aussieW/skill-farting https://github.com/EuripideH/skill-bouddha https://github.com/JarbasSkills/skill-confucius-quotes https://github.com/JarbasSkills/skill-pickup-lines

I'm wary of getting too crazy adding intents in a single skill when the current intent engines scale poorly with number of intents, plus those other skills are unique enough to warrant specific installation, and don't necessarily fit the theme of movies/TV show Easter Eggs. Open to conversation on it though

builderjer commented 7 months ago

To me, most are "What would ____ say?". Maybe farting and pickup-lines are different, but....hmmmm. Could the intents be condensed somehow to just pickup the keyword of the blank above?

mikejgray commented 7 months ago

It's not so much that it doesn't fit the general pattern of "What would ___ say," but that most of them are generally standalone kind of skills. If you want your assistant to fart, you should probably explicitly install that skill. Same idea with pickup lines, confucius quotes, and buddha quotes. I'd personally rather see them get added to a skillstore, maybe with a modernized fork/branch, versus adding them all into this skill. Nothing preventing us from using this as boilerplate to modernize the others

mikejgray commented 6 months ago

@builderjer @JarbasAl For the sake of both making things explicit for users and also boosting the numbers in the skillstore, I'd like to close this issue out in favor of modernizing/re-creating the skills listed above. Thoughts?

builderjer commented 6 months ago

Sounds good to me. @JarbasAl can reopen if he feels otherwise.