OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

ValueError: unknown skill_id: skill-easter-eggs.openvoiceos #31

Closed goldyfruit closed 5 months ago

goldyfruit commented 7 months ago

It seems that the skill ID is not skill-easter-eggs.openvoiceos but skill_easter_eggs.openvoiceos.

mikejgray commented 7 months ago

@goldyfruit What's the installation method? I'm looking at latest dev branch and it's correct

mikejgray commented 7 months ago

Logs from latest dev branch installation:

ovos@mark1-dev:~ $ cat ~/.local/state/mycroft/skills.log | grep easter
2024-01-13 10:50:50.758 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-easter-eggs.openvoiceos
2024-01-13 10:50:50.760 - skill-easter-eggs.openvoiceos - DEBUG - initializing skill settings for skill-easter-eggs.openvoiceos
2024-01-13 10:50:50.798 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.converse.ping
2024-01-13 10:50:50.804 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.converse.request
2024-01-13 10:50:50.807 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.activate
2024-01-13 10:50:50.809 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.deactivate
2024-01-13 10:50:50.833 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.converse.get_response
2024-01-13 10:50:50.834 - skill-easter-eggs.openvoiceos - DEBUG - Adding api method: skill-easter-eggs.openvoiceos.get_display_date
2024-01-13 10:50:50.837 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.get_display_date
2024-01-13 10:50:50.839 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos.public_api
2024-01-13 10:50:51.462 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:GrandmaModeIntent
2024-01-13 10:50:51.478 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:StardateIntent
2024-01-13 10:50:51.494 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:RoboticsLawsIntent
2024-01-13 10:50:51.519 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:PortalIntent
2024-01-13 10:50:51.541 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:rock_paper_scissors_lizard_spock_Intent
2024-01-13 10:50:51.564 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:ArnoldIntent
2024-01-13 10:50:51.587 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:BenderIntent
2024-01-13 10:50:51.602 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:GladosIntent
2024-01-13 10:50:51.618 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:PodBayDoorsIntent
2024-01-13 10:50:51.633 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:DukeNukemIntent
2024-01-13 10:50:51.648 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:AdultModeIntent
2024-01-13 10:50:51.661 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:LanguagesYouSpeakIntent
2024-01-13 10:50:51.668 - skills - ovos_utils.events:add:163 - DEBUG - Added event: skill-easter-eggs.openvoiceos:HALIntent
2024-01-13 10:50:51.701 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-easter-eggs.openvoiceos loaded successfully
goldyfruit commented 7 months ago

https://github.com/OpenVoiceOS/ovos-docker/blob/dev/skills/skill-easter-eggs/Dockerfile#L24

mikejgray commented 7 months ago

https://pypi.org/project/skill-easter-eggs/0.1.2a3/ Would you please validate the version that's pulling down?

goldyfruit commented 7 months ago

Using version 0.1.2a2

mikejgray commented 7 months ago

entry_points.txt on that version:

[ovos.plugin.skill]
skill-easter-eggs.openvoiceos = skill_easter_eggs:EasterEggsSkill

Maybe this is an ovos-skill-launcher issue...

goldyfruit commented 7 months ago

I have no issue with the alerts skill which seems to use the same logic: https://github.com/OpenVoiceOS/ovos-skill-alerts/blob/dev/setup.py#L40

mikejgray commented 7 months ago

@JarbasAl Thoughts on what might be different here? The setup.py files should be almost identical, and I can see in the tarballs that the files look correct.

@goldyfruit Can you validate the version being pulled inside the container?

goldyfruit commented 7 months ago

I wonder if I should use ovos-skill-easter-eggs.openvoiceos instead of skill-easter-eggs.openvoiceos.

Running version 0.1.2a2 in the container.