search

OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

[ENHANCEMENT] Container compatibility #36

Closed mikejgray closed 5 months ago

mikejgray commented 10 months ago 
          consideration, if running in containers the path to the mp3 file wont be available inside ovos-audio

you can check for os.environ.get("IS_OVOS_CONTAINER") and in this case perhaps send the url for the file from github? that would cause OCP to stream it instead of hiting a bad file path

_Originally posted by @JarbasAl in https://github.com/OpenVoiceOS/ovos-skill-easter-eggs/pull/35#discussion_r1452917126_

JarbasAl commented 10 months ago

infodumping somer further context, regular sounds dont need this as they are very small, so they are directly sent via the messagebus embedded in the play sound message

the portal song is much larger, its not a short audio, so for OCP this approach doesnt work