search

OpenVoiceOS / ovos-skill-easter-eggs

fun easter eggs for mycroft
Apache License 2.0
2 stars 4 forks source link

1.0.0 (#44) #45

Closed mikejgray closed 4 months ago

mikejgray commented 4 months ago

The prior copy looked out of place in the rest of the homescreen examples, which are all capitalized and end in punctuation.

remove invalid license header, boilerplate copy paste from ancient times

I'm the original author, in case of doubt the GPL license in header does not apply

resolves ModuleNotFoundError: No module named 'setuptools'

Since this isn't a default skill anywhere, users must install it explicitly, so maintaining support for EOL Python doesn't make a ton of sense. Plus it's making the tests fail.

If the environment variable is set indicating OVOS is running in a container, pass the GitHub URL of the file to OCP instead of the local URL. Naturally only works if the assistant has an internet connection to GitHub.

Only one law at a time when requesting a specific law

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the project's functionality and structure, introducing new dialogues, vocabulary, and constants. The EasterEggsSkill class has been refactored, and new tests have been added. Additionally, the translation files have been expanded for better localization, and dependencies have been updated for improved development and testing.

Changes

File/Directory Change Summary
.github/workflows/skill_tests.yml AI-generated summary of changes
.github/workflows/sync_tx.yml AI-generated summary of changes
.gitignore Excludes the test/skill_fs/ directory from version control
CHANGELOG.md AI-generated summary of changes
README.md Revised examples and corrected formatting in the Credits section
init.py Refactored EasterEggsSkill class, updated imports, added methods, and updated intent handlers
constants.py Added constants ANNUAL and ASCII_SNOW
locale/de-de/... Added vocab and dialogues in German
locale/en-us/... Introduced new dialogues and vocabularies related to various keywords and phrases
requirements/... Introduced new dependencies essential for development and functionality
scripts/... Added scripts for processing and syncing translations
setup.py Updated file path references and dependencies
skill.json Updated examples, requirements, and credits sections
test/... Expanded intent definitions, renamed/added keywords, introduced test suites, and placeholder tests
translations/... Added new dialog, regex, and vocab files for better localization
version.py Updated version numbers and introduced VERSION_ALPHA constant

Assessment against linked issues

Objective Addressed Explanation
Create rule0.dialog (#2) ❓ Specific changes related to rule0.dialog were not identified.

Poem

In the code, a rabbit hops with glee,
New dialogues, constants, and vocab you see,
Translations spread across lands so far,
Easter eggs hidden like a shining star,
Dependencies firm, tests aligned,
The project's brilliance redefined.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.