search

OpenVoiceOS / ovos-tts-plugin-piper

Apache License 2.0
13 stars 9 forks source link

Doesn't handle the "?" properly #16

Closed goldyfruit closed 6 months ago

goldyfruit commented 6 months ago

When using the HTTP server provided by Piper, I don't have any trouble with the punctuation but when using this plugin, the "?" generates some trouble as I don't get any thing after it.

It seems to be related to "?" which should be escaped.

Sentence:

Why doesn't the Chimney-Sweep call out sick from work? Because he's used to working with a flue.

Result:

https://tts.smartgic.io/piper/synthesize/Why%20doesn't%20the%20Chimney-Sweep%20call%20out%20sick%20from%20work?%20Because%20he%27s%20used%20to%20working%20with%20a%20flue.?lang=en-us&voice=ryan-high

goldyfruit commented 6 months ago

Just re-validated the issue again with this sentence (from the skill jokes).

Dec 30 18:06:56 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:56.599 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: skill-ovos-icanhazdadjokes.openvoiceos:joke.intent
Dec 30 18:06:56 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:56.651 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: mycroft.skill.handler.start
Dec 30 18:06:57 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:57.108 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: enclosure.active_skill
Dec 30 18:06:57 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:57.149 - HiveMind-voice-sat - ovos_audio.service:execute_tts:348 - INFO - Speak: What's Forest Gump's Facebook password? 1forest1

TTS didn't play "1forest1".