OpenVoiceOS / ovos-tts-server-plugin

Apache License 2.0
0 stars 4 forks source link

Make TLS verification configurable #11

Closed mikejgray closed 9 months ago

mikejgray commented 9 months ago

As reported in Matrix:

Dec 31 13:03:11 furby ovos-dinkum-listener[2623]: 2023-12-31 13:03:11.961 - voice - ovos_stt_plugin_server:execute:32 - ERROR - HTTPSConnectionPool(host='ovos-stt-server.dc', port=443): Max retries exceeded with url: /stt?lang=en-us (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)')))

The verification process (basically setting requests verify=true) should default to true, but be exposed as a configuration option, with a warning to users that setting it to false is insecure. A second iteration might include links to how to fix this issue in a more secure way.

mikejgray commented 9 months ago

https://github.com/OpenVoiceOS/ovos-tts-server-plugin/blob/ae866d7264a5794e6adc664504b58655ddcda7fb/ovos_tts_plugin_server/__init__.py#L45