search

OpenVoiceOS / ovos-tts-server-plugin

Apache License 2.0
0 stars 4 forks source link

shuffle only public servers #17

Closed builderjer closed 8 months ago

builderjer commented 9 months ago

This is a breaking change, let's please deprecate the old name and return the new in that property.

Not sure its breaking, as it still pulls the same name in the config, just adds hosts to include several

Also, there's 100% unit test coverage and extensive e2e coverage...those need to be updated 🙂

I will go through this

builderjer commented 9 months ago

I could use some help on the last 2 failing sections. I'm not sure the issue here at all.

mikejgray commented 9 months ago

See comments, and also please add tests to validate your new logic. Test coverage is at 100% and I'd like to keep it there. Let me know if you want some help writing new tests

Bah, and here we see the failings of codecov...it's still showing 100% coverage even though there are no tests to validate the new logic. 🙂 Let's please add them anyway