search

OpenVoiceOS / ovos-utils

Apache License 2.0
3 stars 8 forks source link

Add backwards-compat imports with deprecation warnings #209

Closed NeonDaniel closed 10 months ago

NeonDaniel commented 10 months ago

Addresses failures: https://github.com/NeonGeckoCom/NeonCore/pull/599

codecov[bot] commented 10 months ago

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (f92fe7c) 38.63% compared to head (938e9a6) 48.15%.

:exclamation: Current head 938e9a6 differs from pull request most recent head c313a25. Consider uploading reports for the commit c313a25 to get more accurate results

Files Patch % Lines
ovos_utils/sound.py 17.39% 57 Missing :warning:
ovos_utils/skills.py 7.14% 13 Missing :warning:
ovos_utils/messagebus.py 38.88% 11 Missing :warning:
ovos_utils/version.py 0.00% 3 Missing :warning:
ovos_utils/signal.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ========================================== + Coverage 38.63% 48.15% +9.51% ========================================== Files 78 28 -50 Lines 7283 2276 -5007 ========================================== - Hits 2814 1096 -1718 + Misses 4469 1180 -3289 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JarbasAl commented 10 months ago

dev branch already is on 0.1.0a1

last stable release should have all th deprecation warnings, this would need to be a manual post release

NeonDaniel commented 10 months ago

dev branch already is on 0.1.0a1

last stable release should have all th deprecation warnings, this would need to be a manual post release

Rebased on master and manually specified a post version