codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 3.33333% with 29 lines in your changes are missing coverage. Please review.
Project coverage is 42.29%. Comparing base (
404b7fc) to head (7062f21). Report is 2 commits behind head on dev.
| Files | Patch % | Lines |
|---|---|---|
| ovos_utils/file_utils.py | 7.14% | 13 Missing :warning: |
| ovos_utils/signal.py | 0.00% | 10 Missing :warning: |
| ovos_utils/process_utils.py | 0.00% | 6 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #249 +/- ## ========================================== - Coverage 42.39% 42.29% -0.11% ========================================== Files 31 31 Lines 3064 3076 +12 ========================================== + Hits 1299 1301 +2 - Misses 1765 1775 +10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
we already deprecated usage of this everywhere in ovos, only the utils remain
in some circumstances, depending on workdir, python also gets confused with importing signal, as it tries to use the relative import for ovos_utils.signal, imports moved to where they are used to minimize this impact
this also allows process_utils.py to be imported under windows as reported by @mikejgray