Closed JarbasAl closed 1 week ago
[!CAUTION]
Review failed
The pull request is closed.
The changes involve modifications to the MANIFEST.in
file, including the removal of several directory inclusions and the addition of a new directory for recursive inclusion. A new JSON file for the "Naptime" skill has been added, while an existing JSON file related to the Mycroft AI platform has been deleted. Additionally, the setup.py
file has been updated to reduce the scope of resource directories. Several unit test files have been removed, which were designed to validate various functionalities related to licensing and skill installation.
File Path | Change Summary |
---|---|
MANIFEST.in | Removed recursive includes for dialog , vocab , res , ui ; added recursive include for gui ; removed JSON file inclusion; retained text file inclusion. |
locale/en-us/skill.json | Added new skill metadata for "Naptime" including skill_id , source , name , description , examples , and tags . |
res/desktop/skill.json | Removed the file containing metadata for the "Naptime" skill for Mycroft AI. |
setup.py | Modified find_resource_files to include only locale and gui directories. |
test/license_tests.py | Removed the TestLicensing class that validated licensing for ovos-skill-naptime . |
test/osm_tests.py | Removed the TestOSM class that tested skill installation from a GitHub repository. |
test/plugin_tests.py | Removed the TestPlugin class that verified the presence of a skill plugin. |
test/unittests/osm_tests.py | Removed the TestOSM class that validated installation functionality for a skill from a GitHub repository. |
sequenceDiagram
participant User
participant Assistant
participant Skill
User->>Assistant: "Go to sleep"
Assistant->>Skill: Activate Naptime Skill
Skill-->>Assistant: Enter sleep mode
Assistant-->>User: "Assistant is now asleep."
🐰 "In the code, some changes took place,
A new skill for naps, oh what a grace!
Old tests have hopped away,
As the GUI finds its way,
In the world of code, we embrace!" 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores
These changes improve user experience by refining skill functionality and maintaining a cleaner project structure.