search

OpenVoiceOS / skill-ovos-setup

OpenVoiceOS Setup Skill - configure your device and optionally connect it to a backend server
https://mycroft.ai/skills
Apache License 2.0
1 stars 5 forks source link

restart on end of setup or ww engine will not work #52

Closed AIIX closed 1 year ago

AIIX commented 1 year ago
JarbasAl commented 1 year ago

why doesnt it work? this PR seems the wrong thing to do, do you have logs about the error so we can fix it in proper place instead of such a drastic ugly hack?

AIIX commented 1 year ago

why doesnt it work? this PR seems the wrong thing to do, do you have logs about the error so we can fix it in proper place instead of such a drastic ugly hack?

There are no error logs except -> https://github.com/OpenVoiceOS/ovos-core/issues/216 but ww engine never responds to wakeword at all until a reboot

AIIX commented 1 year ago

LOG after setup has completed: even talking loudly into the device mic does not work until reboot after first setup

2022-10-19 00:09:16.170 - voice - mycroft.listener.stt:create:12 - INFO - Creating STT engine: ovos-stt-plugin-chromium
2022-10-19 00:09:27.722 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4810.733333333334
2022-10-19 00:09:28.022 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4959.25
2022-10-19 00:09:28.035 - voice - mycroft.listener.mic:listen:905 - DEBUG - Waiting for wake word...
2022-10-19 00:09:30.055 - voice - ovos_config.config:_on_file_change:269 - INFO - /home/mycroft/.config/mycroft/mycroft.conf changed on disk, reloading!
2022-10-19 00:09:30.066 - voice - ovos_config.models:load_local:95 - DEBUG - Configuration /home/mycroft/.config/mycroft/mycroft.conf loaded
2022-10-19 00:09:30.237 - voice - mycroft.listener:run:508 - DEBUG - Config has changed, reloading...
2022-10-19 00:09:32.863 - voice - mycroft.listener:_load_config:322 - DEBUG - Using microphone (None = default): None
2022-10-19 00:09:32.865 - voice - mycroft.listener:create_hotword_engines:331 - INFO - creating hotword engines
2022-10-19 00:09:32.886 - voice - ovos_plugin_manager.wakewords:load_module:85 - INFO - Loading "hey_mycroft" wake word via ovos-ww-plugin-precise
2022-10-19 00:09:33.047 - voice - ovos_plugin_manager.wakewords:load_module:92 - INFO - Loaded the Wake Word plugin ovos-ww-plugin-precise
2022-10-19 00:09:33.061 - voice - ovos_plugin_manager.wakewords:load_module:85 - INFO - Loading "wake_up" wake word via ovos-ww-plugin-pocketsphinx
2022-10-19 00:09:33.621 - voice - ovos_plugin_manager.wakewords:load_module:92 - INFO - Loaded the Wake Word plugin ovos-ww-plugin-pocketsphinx
2022-10-19 00:09:33.697 - voice - mycroft.listener:create_hotword_engines:395 - ERROR - Failed to load hotword: lang
2022-10-19 00:09:33.758 - voice - mycroft.listener.mic:__init__:362 - INFO - VAD method: vad_and_ratio
2022-10-19 00:09:33.765 - voice - mycroft.listener.mic:__init__:368 - INFO - Creating VAD engine: ovos-vad-plugin-webrtcvad
2022-10-19 00:09:33.784 - voice - ovos_plugin_manager.utils:load_plugin:102 - WARNING - Could not find the plugin ovos.plugin.VAD.ovos-vad-plugin-webrtcvad
2022-10-19 00:09:33.797 - voice - ovos_plugin_manager.vad:create:77 - ERROR - VAD plugin ovos-vad-plugin-webrtcvad could not be loaded!
2022-10-19 00:09:33.810 - voice - mycroft.listener.mic:__init__:373 - ERROR - Failed to load VAD plugin!
2022-10-19 00:09:33.819 - voice - mycroft.listener.mic:__init__:377 - WARNING - vad_and_ratio selected, but VAD plugin not available!
2022-10-19 00:09:33.822 - voice - mycroft.listener.mic:__init__:379 - WARNING - Casting silence method to ratio_only
2022-10-19 00:09:34.875 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4566.4
2022-10-19 00:09:35.169 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4434.0
2022-10-19 00:09:35.175 - voice - mycroft.listener.mic:listen:905 - DEBUG - Waiting for wake word...
2022-10-19 00:10:57.507 - voice - ovos_config.config:_on_file_change:269 - INFO - /home/mycroft/.config/mycroft/mycroft.conf changed on disk, reloading!
2022-10-19 00:10:57.597 - voice - ovos_config.models:load_local:95 - DEBUG - Configuration /home/mycroft/.config/mycroft/mycroft.conf loaded
2022-10-19 00:10:57.819 - voice - mycroft.listener:run:508 - DEBUG - Config has changed, reloading...
2022-10-19 00:10:58.958 - voice - mycroft.listener:_load_config:322 - DEBUG - Using microphone (None = default): None
2022-10-19 00:10:58.962 - voice - mycroft.listener:create_hotword_engines:331 - INFO - creating hotword engines
2022-10-19 00:10:58.970 - voice - ovos_plugin_manager.wakewords:load_module:85 - INFO - Loading "hey_mycroft" wake word via ovos-ww-plugin-precise
2022-10-19 00:10:59.406 - voice - ovos_plugin_manager.wakewords:load_module:92 - INFO - Loaded the Wake Word plugin ovos-ww-plugin-precise
2022-10-19 00:10:59.422 - voice - ovos_plugin_manager.wakewords:load_module:85 - INFO - Loading "wake_up" wake word via ovos-ww-plugin-pocketsphinx
2022-10-19 00:11:00.313 - voice - ovos_plugin_manager.wakewords:load_module:92 - INFO - Loaded the Wake Word plugin ovos-ww-plugin-pocketsphinx
2022-10-19 00:11:00.456 - voice - mycroft.listener:create_hotword_engines:395 - ERROR - Failed to load hotword: lang
2022-10-19 00:11:00.613 - voice - mycroft.listener.mic:__init__:362 - INFO - VAD method: vad_and_ratio
2022-10-19 00:11:00.616 - voice - mycroft.listener.mic:__init__:368 - INFO - Creating VAD engine: ovos-vad-plugin-webrtcvad
2022-10-19 00:11:00.658 - voice - ovos_plugin_manager.utils:load_plugin:102 - WARNING - Could not find the plugin ovos.plugin.VAD.ovos-vad-plugin-webrtcvad
2022-10-19 00:11:00.660 - voice - ovos_plugin_manager.vad:create:77 - ERROR - VAD plugin ovos-vad-plugin-webrtcvad could not be loaded!
2022-10-19 00:11:00.662 - voice - mycroft.listener.mic:__init__:373 - ERROR - Failed to load VAD plugin!
2022-10-19 00:11:00.664 - voice - mycroft.listener.mic:__init__:377 - WARNING - vad_and_ratio selected, but VAD plugin not available!
2022-10-19 00:11:00.666 - voice - mycroft.listener.mic:__init__:379 - WARNING - Casting silence method to ratio_only
2022-10-19 00:11:01.785 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4607.8
2022-10-19 00:11:02.181 - voice - mycroft.listener.mic:adjust_for_ambient_noise:982 - INFO - Silence threshold adjusted to 4677.75
2022-10-19 00:11:02.185 - voice - mycroft.listener.mic:listen:905 - DEBUG - Waiting for wake word...
2022-10-19 00:11:06.257 - voice - ovos_config.config:_on_file_change:269 - INFO - /home/mycroft/.config/mycroft/mycroft.conf changed on disk, reloading!
2022-10-19 00:11:06.329 - voice - ovos_config.models:load_local:95 - DEBUG - Configuration /home/mycroft/.config/mycroft/mycroft.conf loaded
JarbasAl commented 1 year ago

i really really REALLY dislike this change, if you must do it then:

in the end this will just hide a bug that needs proper fixing and is unrelated to this skill, it is very hacky and only acceptable as a workaround so you can ship an image

NeonDaniel commented 1 year ago

i really really REALLY dislike this change, if you must do it then:

  • maybe use restart instead of reboot, no need to restart full OS
  • put it all behind skill settings and disabled by default, this is very platform specific, enable it in images that need it
  • perhaps allow settings to define if it wants reboot or a list of services to restart (you only need to restart speech for your bug)

in the end this will just hide a bug that needs proper fixing and is unrelated to this skill, it is very hacky and only acceptable as a workaround so you can ship an image

Doesn't affect Neon; might be related to this block in _load_config: https://github.com/NeonGeckoCom/neon_speech/blob/dev/neon_speech/listener.py#L139-L146

AIIX commented 1 year ago

Closing this as this issue is no longer applicable