search

OpenVoiceOS / skill-ovos-weather

OpenVoiceOS official Weather Skill, providing weather conditions and forecasts.
Apache License 2.0
1 stars 4 forks source link

night time weather icon #28

Open builderjer opened 1 year ago

builderjer commented 1 year ago

I am creating this issue here so I don't forget. The weather icon does not change from "sun" to "moon" after sunset. The neon version does, and all of the icons are present, so it probably just needs to check the time against 'sunset' and 'sunrise'.

emphasize commented 1 year ago

maybe we can add a little twist. Even though it's nighttime i'd probably like to know the condition (cloudy, rain, etc.) if i can squeeze time, i'll check the options.

builderjer commented 1 year ago

Yes, all of the icons are there, just not added

emphasize commented 1 year ago

That involves work on both weather and homescreen skill btw. Weather sends a code 0-7 and based on that homescreen is showing the svg.

I'm looking into overlay moon + condition a make them code 01, 02, ...

builderjer commented 1 year ago

neons weather skill works with all of the icons and the same homescreen as ovos

https://github.com/NeonGeckoCom/skill-weather

emphasize commented 1 year ago

notice that this is kind of a hack neon uses. It doesn't send a code, but the image location of the homescreen skill image. (Both skills setting the code of sun and moon to 0, homescreen doesn't have a code for moon)

Furthermore it only differentiates between night and night(cloudy). The other conditions fall flat. I intend to also map other conditions (rain, wind, ...)

builderjer commented 1 year ago

Nice!!

emphasize commented 1 year ago

Looking at the code it's relatively easy. is_day is passed to the Condition class. Just the map has to be expanded/broken down, overlays like night cloudy to be created and the additional code sent to homescreen expanded.

emphasize commented 1 year ago

On a second look, not that easy compat-wise.

Neon doesn't care about Mark1. And we are stuck because of that. I think @JarbasAl has to step in for suggestions.

builderjer commented 1 year ago

neon has their own weather skill

JarbasAl commented 1 year ago

On a second look, not that easy compat-wise.

Neon doesn't care about Mark1. And we are stuck because of that. I think @JarbasAl has to step in for suggestions.

dont worry about the Mk1 , it is not officially supported yet and the new codes should be handled there too!

JarbasAl commented 1 year ago

neon has their own weather skill

not sure what the differences are, other than using the NeonMQ backend proxy instead of OpenMeteo as provider

but skills should be synced if Neon is diverging in anything other than provider, I assumed that was the case already with PRs being sent here

builderjer commented 1 year ago

Yes, I sent it here because neon already handled it, even if it is hacky