The still existing CamelCase references were brought in line with the voc filename stem. Personally i don't know if camelcase is resolved in adapt, but its something hidden in the code that is just unnecessary. (and weather forcast intents already do it like that)
this only affected condition requests, that's why it must have slipped through the cracks
historically the pattern has been to use CamelCase, but that is not a requirement and skills in the wild vary greatly, when this skill "was made great again" i suppose these were missed
Problem:
message.data
is also capitalized.location
is accessed lowercase. To be consistent all entity references were defined lowercase. https://github.com/OpenVoiceOS/skill-ovos-weather/blob/adbb8471fd7981c1a5a8938fad63ce26e990451a/skill/intent.py#L39this only affected condition requests, that's why it must have slipped through the cracks