OpenVoiceOS / skill-ovos-weather

OpenVoiceOS official Weather Skill, providing weather conditions and forecasts.
Apache License 2.0
1 stars 4 forks source link

extend intents #47

Closed JarbasAl closed 1 year ago

JarbasAl commented 1 year ago

report any currently failing utterances that should match a weather intent here please

codecov[bot] commented 1 year ago

Codecov Report

Merging #47 (d665eb5) into dev (6a3be70) will decrease coverage by 3.47%. The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #47      +/-   ##
==========================================
- Coverage   29.57%   26.10%   -3.47%     
==========================================
  Files           9        8       -1     
  Lines        1055     1061       +6     
==========================================
- Hits          312      277      -35     
- Misses        743      784      +41     
Flag Coverage Δ
unittests 26.10% <ø> (-3.47%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

mikejgray commented 1 year ago

Additional suggestions

is there a storm coming
is there a chance of showers
emphasize commented 1 year ago

is there a storm coming

would need a new intent/condition handling

is there a chance of showers

Handled with handle_next_precipitation? Regardless, this raises the question if when.voc and query.voc shouldn't be merged. "when" is a query. Or, as Jarbas suggested transition to padatious. Both out of scope here.

I'm disentangling this and will open a new issue to propose such new stuff. Want to get the language support ASAP.