OpenVoiceOS / skill-ovos-weather

OpenVoiceOS official Weather Skill, providing weather conditions and forecasts.
Apache License 2.0
1 stars 4 forks source link

add time specific requests #51

Closed emphasize closed 1 year ago

emphasize commented 1 year ago

Problem:

hourly weather is atm restricted to daytime requests (noon/afternoon/evening/morning/night/midnight)

this parses the intent datetime and based on this the timeframe is chosen. consolidates weather intents into one routing the intents to the appropriate handler

codecov[bot] commented 1 year ago

Codecov Report

Merging #51 (5f69d7b) into dev (e2add03) will decrease coverage by 0.43%. The diff coverage is 22.22%.

@@            Coverage Diff             @@
##              dev      #51      +/-   ##
==========================================
- Coverage   26.57%   26.14%   -0.43%     
==========================================
  Files           8        8              
  Lines        1095     1090       -5     
==========================================
- Hits          291      285       -6     
- Misses        804      805       +1     
Flag Coverage Δ
unittests 26.14% <22.22%> (-0.43%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
weather_helpers/intent.py 36.92% <0.00%> (-0.58%) :arrow_down:
__init__.py 25.36% <23.52%> (-1.08%) :arrow_down: