OpenVoiceOS / skill-ovos-wikipedia

wikipedia skill for mycroft
Apache License 2.0
7 stars 8 forks source link

fix common query #11

Closed JarbasAl closed 1 year ago

JarbasAl commented 1 year ago
2023-03-29 18:30:02.755 - skills - mycroft.skills.intent_service:_normalize_all_utterances:61 - DEBUG - Utterances: [('what do you do',)]
2023-03-29 18:30:02.816 - skills - mycroft.skills.intent_services.padatious_service:_match_level:87 - DEBUG - Padatious Matching confidence > 0.95
2023-03-29 18:30:02.817 - skills - mycroft.skills.intent_services.commonqa_service:handle_question:119 - INFO - Searching for what do you do
2023-03-29 18:30:04.586 - skills - mycroft.skills.intent_services.commonqa_service:handle_query_response:153 - INFO - Answer from skill-ovos-wikipedia.openvoiceos
2023-03-29 18:30:04.586 - skills - mycroft.skills.intent_services.commonqa_service:_query_timeout:173 - INFO - Timeout occurred check responses
2023-03-29 18:30:04.587 - skills - mycroft.skills.intent_services.commonqa_service:_query_timeout:198 - INFO - Handling with: skill-ovos-wikipedia.openvoiceos
2023-03-29 18:30:07.632 - skills - ovos_workshop.skills.base:_on_event_error:1230 - ERROR - 'title'
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_utils/messagebus.py", line 351, in wrapper
    handler(message)
  File "/home/ovos/.venv/lib/python3.11/site-packages/mycroft/skills/common_query_skill.py", line 185, in __handle_query_action
    self.CQS_action(phrase, data)
  File "/home/ovos/.local/share/mycroft/skills/skill-ovos-wikipedia.openvoiceos/__init__.py", line 105, in CQS_action
    self.set_context("WikiKnows", data["title"])
                                  ~~~~^^^^^^^^^
KeyError: 'title'
builderjer commented 1 year ago

This is not the error I get with wikipedia. I get

2023-03-30 07:50:36.580 - skills - mycroft.skills.intent_services.commonqa_service:handle_question:119 - INFO - Searching for ask wikipedia about elon musk
2023-03-30 07:50:36.847 - skills - ovos_workshop.skills.base:_on_event_error:1230 - ERROR - not enough values to unpack (expected 4, got 2)
Traceback (most recent call last):
  File "/home/ovos/.local/lib/python3.10/site-packages/ovos_utils/messagebus.py", line 351, in wrapper
    handler(message)
  File "/home/ovos/.local/lib/python3.10/site-packages/mycroft/skills/common_query_skill.py", line 106, in __handle_question_query
    result = self.CQS_match_query_phrase(search_phrase)
  File "/home/ovos/.local/lib/python3.10/site-packages/skill_ovos_wikipedia/__init__.py", line 94, in CQS_match_query_phrase
    summary = self.ask_the_wiki(utt)
  File "/home/ovos/.local/lib/python3.10/site-packages/skill_ovos_wikipedia/__init__.py", line 113, in ask_the_wiki
    self.results = self.wiki.long_answer(query, lang=self.lang)
  File "/usr/lib/python3.10/site-packages/neon_solvers/solver.py", line 195, in long_answer
    steps = self.get_expanded_answer(query, context)
  File "/home/ovos/.local/lib/python3.10/site-packages/neon_solver_wikipedia_plugin/__init__.py", line 129, in get_expanded_answer
    data = self.get_data(query, context)
  File "/home/ovos/.local/lib/python3.10/site-packages/neon_solver_wikipedia_plugin/__init__.py", line 95, in get_data
    "short_answer": wikipedia_for_humans.tldr(query, lang=lang),
  File "/home/ovos/.local/lib/python3.10/site-packages/wikipedia_for_humans/__init__.py", line 397, in tldr
    return short_answer(query, lang)
  File "/home/ovos/.local/lib/python3.10/site-packages/wikipedia_for_humans/__init__.py", line 356, in short_answer
    answer = summary(query, lang)
  File "/home/ovos/.local/lib/python3.10/site-packages/wikipedia_for_humans/__init__.py", line 346, in summary
    results = search_wikipedia(query, limit=1)
  File "/home/ovos/.local/lib/python3.10/site-packages/wikipedia_for_humans/__init__.py", line 130, in search_wikipedia
    _, results, _, urls = r.json()
ValueError: not enough values to unpack (expected 4, got 2)
2023-03-30 07:50:47.628 - skills - mycroft.skills.intent_services.commonqa_service:_query_timeout:173 - INFO - Timeout occurred check responses