OpenVoiceOS / skill-ovos-wikipedia

wikipedia skill for mycroft
Apache License 2.0
7 stars 8 forks source link

Skill is totally lost when the assistant is not set in English #25

Closed goldyfruit closed 5 months ago

goldyfruit commented 5 months ago

My assistant is configured to run in French but If I ask "qui est steve job", the assistant answer something totally wrong and in English...

Mar 30 10:37:15 neon ovos-core[1759]: 2024-03-30 10:37:15.939 - skills - ovos_core.transformers:transform:61 - DEBUG - ovos-utterance-cancel: {}
Mar 30 10:37:15 neon ovos-core[1759]: 2024-03-30 10:37:15.941 - skills - ovos_core.transformers:transform:64 - WARNING - ovos-utterance-corrections transform exception: list index out of range
Mar 30 10:37:15 neon ovos-core[1759]: 2024-03-30 10:37:15.945 - skills - ovos_core.transformers:transform:61 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcription': 'qui est Steve Jobs', 'lang': 'fr-fr'}
Mar 30 10:37:15 neon ovos-core[1759]: 2024-03-30 10:37:15.951 - skills - ovos_core.intent_services:get_pipeline:260 - DEBUG - Session pipeline: ['stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'fallback_medium', 'fallback_low']
Mar 30 10:37:15 neon ovos-core[1759]: 2024-03-30 10:37:15.952 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x7fa1a69010>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.018 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x7fa1a69b50>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.019 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.022 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method PadatiousMatcher.match_high of <ovos_core.intent_services.padatious_service.PadatiousMatcher object at 0x7f9a5a7690>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.027 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method AdaptService.match_high of <ovos_core.intent_services.adapt_service.AdaptService object at 0x7fb2402e90>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.029 - skills - ovos_core.intent_services.fallback_service:_collect_fallback_skills:102 - INFO - checking for FallbackSkillsV2 candidates
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.031 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.047 - skills - ovos_workshop.skills.fallback:handler:115 - DEBUG - Checking fallbacks in range 0 - 5
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.100 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method FallbackService.high_prio of <ovos_core.intent_services.fallback_service.FallbackService object at 0x7fa11ff6d0>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.102 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method StopService.match_stop_medium of <ovos_core.intent_services.stop_service.StopService object at 0x7fa1a69010>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.103 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method AdaptService.match_medium of <ovos_core.intent_services.adapt_service.AdaptService object at 0x7fb2402e90>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.104 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.8
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.105 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method PadatiousMatcher.match_medium of <ovos_core.intent_services.padatious_service.PadatiousMatcher object at 0x7f9a5a7690>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.106 - skills - ovos_core.intent_services:handle_utterance:375 - DEBUG - no match from <bound method AdaptService.match_low of <ovos_core.intent_services.adapt_service.AdaptService object at 0x7fb2402e90>>
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.108 - skills - ovos_core.intent_services.commonqa_service:match:147 - INFO - Gathering answers from skills: ['skill-ovos-wikipedia.openvoiceos']
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.113 - skills - ovos_core.intent_services.commonqa_service:handle_question:178 - INFO - Searching for qui est Steve Jobs
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.168 - skill-ovos-wikipedia.openvoiceos - DEBUG - skipping auto translation for wikipedia, fr-fr is supported
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.174 - skills - ovos_core.intent_services.commonqa_service:handle_query_response:218 - DEBUG - skill-ovos-wikipedia.openvoiceos is searching
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.912 - skill-ovos-wikipedia.openvoiceos - INFO - Wikipedia answer: Luca de Meo (born 13 June 1967) is an Italian automotive executive who is currently the CEO of Renault Group.
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.928 - skills - ovos_core.intent_services.commonqa_service:handle_query_response:227 - INFO - Answer from skill-ovos-wikipedia.openvoiceos
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.929 - skills - ovos_core.intent_services.commonqa_service:handle_query_response:234 - DEBUG - Done waiting for skill-ovos-wikipedia.openvoiceos
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.930 - skills - ovos_core.intent_services.commonqa_service:handle_query_response:239 - DEBUG - All skills answered
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.932 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:261 - INFO - Check responses with 1 replies
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.936 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:288 - INFO - Handling with: skill-ovos-wikipedia.openvoiceos
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.939 - skills - ovos_core.intent_services.commonqa_service:handle_question:201 - DEBUG - answered=True|remaining active_queries=0
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.943 - skills - ovos_core.intent_services:handle_utterance:381 - DEBUG - intent matching took: 0.9912583827972412
Mar 30 10:37:16 neon ovos-core[1759]: 2024-03-30 10:37:16.980 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session
Dante1975X commented 5 months ago

I'm experiencing the same when using the wikipedia skill in German.

goldyfruit commented 5 months ago

@Dante1975X this file has to be translated in German https://github.com/OpenVoiceOS/skill-ovos-wikipedia/blob/dev/locale/en-us/query.intent to work for you. :+1:

Dante1975X commented 5 months ago

@Dante1975X this file has to be translated in German https://github.com/OpenVoiceOS/skill-ovos-wikipedia/blob/dev/locale/en-us/query.intent to work for you. 👍

The actual German query.intent file looks fine for me. Only in the German wiki.intent file are still the two wrong ")" instead of "}"

When will there be new docker images again, so I can test the changes for me? (The last docker images seem to be 5 days old?)

goldyfruit commented 5 months ago

When will there be new docker images again, so I can test the changes for me? (The last docker images seem to be 5 days old?)

Image has been rebuild 18 hours ago, https://hub.docker.com/r/smartgic/ovos-skill-wikipedia

Dante1975X commented 5 months ago

When will there be new docker images again, so I can test the changes for me? (The last docker images seem to be 5 days old?)

Image has been rebuild 18 hours ago, https://hub.docker.com/r/smartgic/ovos-skill-wikipedia

Okay. I managed now the update and the German intents from the query.intent file are now working. But from the wiki.intent file no intent is working.

goldyfruit commented 5 months ago

@JarbasAl merged a fix, I rebuilt the image with it, try to pull the new one.