search

OpenVoiceOS / skill-ovos-wikipedia

wikipedia skill for mycroft
Apache License 2.0
7 stars 8 forks source link

Update setup.py and GHA to resolve PyPI errors #41

Closed NeonDaniel closed 3 months ago

NeonDaniel commented 3 months ago

Updates release automation to use shared action Resolves version bump error https://github.com/OpenVoiceOS/skill-ovos-wikipedia/actions/runs/9121712937/job/25081332652 Update setup.py to use absolute file paths

Closes #30

JarbasAl commented 3 months ago

we should be moving to https://github.com/OpenVoiceOS/.github/tree/feat/shared_actions1 to adopt the new agreed workflow https://openvoiceos.github.io/ovos-technical-manual/versioning/

i haven't been worrying too much with automations while waiting for this to be ready, just wanted to get current packages on pypi in the meantime, but if we are adopting shared actions then we should get this finished instead

NeonDaniel commented 3 months ago

we should be moving to https://github.com/OpenVoiceOS/.github/tree/feat/shared_actions1 to adopt the new agreed workflow https://openvoiceos.github.io/ovos-technical-manual/versioning/

i haven't been worrying too much with automations while waiting for this to be ready, just wanted to get current packages on pypi in the meantime, but if we are adopting shared actions then we should get this finished instead

I agree but haven't seen that PR finished with some open conversations and no linked runs to validate all of the changes. It may be worth breaking that up to make it easier to validate actions individually or in smaller groups.

Meanwhile, this should close an open issue on this repository and get the skill on PyPI for the first time using the current standard automations.