search

OpenWaterAnalytics / EPANET

The Water Distribution System Hydraulic and Water Quality Analysis Toolkit
MIT License
279 stars 204 forks source link

Removed some compiler warnings #674

Closed jburguete closed 2 years ago

LRossman commented 2 years ago

I suggest that the autoconf scripts be removed from this PR. This is an addition that should be posted as an issue so that the project's community can present their views on it.

samhatchett commented 2 years ago

I agree with @LRossman on the autoconf part. the project is standardized on CMake, which generates build files. changes to that strategy should be discussed more fully

jburguete commented 2 years ago

I agree also. Sorry, I am not yet familiarized with git branches. I did not wanted the second commit here but in my account fork.

samhatchett commented 2 years ago

feel free to resubmit after removing the autoconf additions 👍