search

OpenWaterAnalytics / EPANET

The Water Distribution System Hydraulic and Water Quality Analysis Toolkit
MIT License
280 stars 205 forks source link

Modelling of Pump groups #741

Open eldemet opened 1 year ago

eldemet commented 1 year ago

Hi @LRossman, I was wondering about the dev_pump_battery branch [1]. Apparently, some work has already been done for integrating, is there a conflict in the code we should investigate?

[1] https://github.com/OpenWaterAnalytics/EPANET/compare/dev...dev_pump_battery

LRossman commented 1 year ago

The history of this feature and its implementation indev_pump_battery can be found in issue #532. In short, we agreed that it only made sense to include pump groups (i.e. batteries) if the number of active pumps could be set using both simple and rule-based controls. Since at that time we couldn't decide how to do this with the API's existing simple control functions we parked this feature in the dev_pump_battery branch.

If we were to re-visit this feature again, I would recommend getting around the limitation of the current set of EN_add/get/setcontrol functions by introducing a new set that would accommodate pump groups (e.g., EN_add/get/setpumpgroupcontrol). I originally called this approach too clunky in the prior discussion but now think it's the best option.

eldemet commented 1 year ago

Thank you @LRossman I appreciate your insights on this issue. I will check the discussion and see how we can follow-up on this topic.