search

OpenWaterAnalytics / EPANET

The Water Distribution System Hydraulic and Water Quality Analysis Toolkit
MIT License
280 stars 205 forks source link

adds api support for enabling/disabling controls and rules #751

Closed samhatchett closed 1 year ago

samhatchett commented 1 year ago

As discussed long ago in the Issues tracker. I've added old-style api stubs as well for this functionality.

samhatchett commented 1 year ago

@LRossman thanks for the comments. I agree with using the existing int/bool conventions - makes everything a bit clearer. I'll clean this up.

eladsal commented 1 year ago

Thanks @samhatchett ! We need to add the four new functions to the different header files (pas\vb\def), right? I can probably do that next week if nobody will do that before :)

samhatchett commented 1 year ago

@eladsal sure, sounds good. I'm not as familiar with the pas/vb/def particulars so am happy to leave that in your capable hands. ok to merge this PR then, or would you prefer to wait on those additions?

eladsal commented 1 year ago

@samhatchett yes I'll take care of it. Maybe just update ReleaseNotes2_3.md before you merge.