search

OpenWaterAnalytics / EPANET

The Water Distribution System Hydraulic and Water Quality Analysis Toolkit
MIT License
272 stars 201 forks source link

update workflows to include the header files in the artifact #759

Closed Mariosmsk closed 3 months ago

Mariosmsk commented 3 months ago

Can you merge this, @LRossman, @eladsal? It updates the artifact with the latest header files, and users avoid the effort of searching for them.

LRossman commented 3 months ago

@Mariosmsk after merging your workflows commit my subsequent PR failed the continuous-integration/appveyor/branch test for 32-bit windows with the error messages shown below (the 64-bit build and test was successful as was the continuous-integration/appveyor/pr test).

  Generating Code...
  test_toolkit.vcxproj -> C:\projects\epanet\buildprod\bin\Release\test_toolkit.exe
  Building Custom Rule C:/projects/epanet/CMakeLists.txt
cd %EPANET_HOME%
tools\before-test.cmd %PLATFORM% %REF_BUILD_ID% %SUT_BUILD_ID% %APPVEYOR_REPO_COMMIT%
INFO: Staging files for regression testing
curl: (6) Could not resolve host: github.com
curl: (6) Could not resolve host: github.com
ERROR: The system cannot find the file specified.
examples.zip
System ERROR:
The system cannot find the file specified.
ERROR: The system cannot find the file specified.
benchmark.zip
System ERROR:
The system cannot find the file specified.
ERROR: The system cannot find the file specified.
benchmark.zip
System ERROR:
The system cannot find the file specified

I'm assuming the failure has something to do with the update you made to the workflows files. Could you please look into this and see if you can find what the problem might be. Thanks.

P.S. Why is there both a continuous-integration/appveyor/branch and continuous-integration/appveyor/pr test -- they seem to be doing the same thing.

Mariosmsk commented 3 months ago

Hi @LRossman, I think is something different because I made changes only on GitHub workflows. However, I will make a new pull request to update the workflows to avoid the warnings and I will check it.

image

Mariosmsk commented 3 months ago

Important updates A single continuous-integration/appveyor GitHub commit status was replaces with two separate statuses: continuous-integration/appveyor/branch and continuous-integration/appveyor/pr for regular “push” and PR builds respectively.

https://www.appveyor.com/updates/2015/11/06/