dmnd_setmodel() type argument is integer

OpenWaterAnalytics / epanet-python

python wrapper for epanet library

76 stars 40 forks source link

dmnd_setmodel() type argument is integer #51

Closed pshassett closed 4 years ago

pshassett commented 5 years ago

dmnd_setmodel(ph: 'Handle', type: 'int', pmin: 'double', preq: 'double', pexp: 'double') -> "int":

To match the rest of the toolkit wrapper, shouldn't the type of type be EN.DemandModel enum?

Calling EN.dmnd_setmodel(ph, EN.DemandModel.PDA, pmin, preq, pexp) raises 'TypeError: in method 'dmnd_setmodel', argument 2 of type 'int'' in spyder.

samhatchett commented 4 years ago

I'm grooming the backlog here - I think this issue relates to the swig-wrapped package devised by Tryby - so unless he wants to offer support on it, I'll suggest closing.

pshassett commented 4 years ago

It is in regard to the epanet_python module. This was a more nuanced inconsistency, I think it can be closed for the time being.