search

OpenWaterAnalytics / epanet-python

python wrapper for epanet library
76 stars 40 forks source link

Error in CMakeLists.txt - Ws7 & VS 2019 #62

Closed pajarrige closed 3 years ago

pajarrige commented 4 years ago

Trying to generate whl for py 3.8-32 (python 3.8.5) under Ws7 / VS2019, the chain fails to generate .whl. The fix consists in removing the 'Release' path chunk from the last two copy commands from /bin/Release and /lib/Release CMakeLists.txt

samhatchett commented 3 years ago

Thanks for the note - @sm-rana do you have any thoughts on this? I want to make sure this still works for Windows users.

sm-rana commented 3 years ago

Trying to generate whl for py 3.8-32 (python 3.8.5) under Ws7 / VS2019, the chain fails to generate .whl. The fix consists in removing the 'Release' path chunk from the last two copy commands from /bin/Release and /lib/Release CMakeLists.txt

@samhatchett I just tried compiling with VS 2017 (MSVC 14.16.27023) and I agree with @pajarrige the Release folder is not being created under /bin or /lib and getting rid of Release allowed it to compile successfully.

samhatchett commented 3 years ago

Thanks all - PRs are welcome!

samhatchett commented 3 years ago

Closing as fixed - thanks @samrensenhouse !