OpenWaterAnalytics / epanet-rtx

Real-time extension to the EPANET hydraulic toolkit
Other
58 stars 43 forks source link

gain modulartimeseries units #109

Closed jamesuber closed 7 years ago

jamesuber commented 7 years ago

gain does not properly set its units when fed by a raw data source (and thus w/o a clock).

for example, a data source with gpm units fed to a dimensionless gain, shows resulting units as "no units" and all units are possible. Explicitly setting the output gain units to gpm is allowed and seems to work.

Gain works properly when fed by a constant timeseries with a clock.

samhatchett commented 7 years ago

can't replicate. is there more to this issue, like loading from a saved state?