search

OpenWaterAnalytics / epanet-rtx

Real-time extension to the EPANET hydraulic toolkit
Other
58 stars 43 forks source link

testing framework #111

Open bradleyjeck opened 7 years ago

bradleyjeck commented 7 years ago

it's great to see some unit tests coming into the project! As there are not too many tests yet, I was curious how much thought had been given to the test framework? Over on a branch of epanet-dev, I started adding a tests under the CMake framework https://github.com/bradleyjeck/epanet-dev/tree/structure-for-testing

An advantage of using CMake is that it does not introduce another dependency like Boost. Of course Boost and other frameworks have their own advantages. Just thought it might be worth opening the topic while making a change is easy.

samhatchett commented 7 years ago

Hey @bradleyjeck - did you mean to post this on the EPANET project?

RTX uses BOOST already so I wouldn't view this as an extra dependency. That also answers the other question about how much thought went into it -- since BOOST is an existing requirement, and is header-only, I figured it would be easy to integrate.

bradleyjeck commented 7 years ago

Hi @samhatchett - thanks for the feedback. Posting here was intentional as I was curious about the choice for this project. RTX has good reasons for Boost which is great. That may attract other related projects like EPANET in the same direction.