search

OpenWaterAnalytics / epanet-rtx

Real-time extension to the EPANET hydraulic toolkit
Other
58 stars 43 forks source link

Model element statuses can be overridden by Epanet if specified in a control, even if control is disabled #96

Closed jamesuber closed 8 years ago

jamesuber commented 8 years ago

Found this out by noticing that a pump that had a status boundary = 0 could be turned on by Epanet, e.g. 

        Pump TR_PUMP_1 switched from closed to open

apparently because the element appears in a disabled control rule. If the control is completely eliminated then Epanet leaves it alone, as expected.

Bottom line is that disabling control rules is not completely "disabling" them, as currently implemented. Not sure if this is really an RTX issue or better in Epanet, but it's here since RTX is the thing that cares.

jamesuber commented 8 years ago

Case where this happens is flint-4.inp with controls uncommented, simulation from 3/10/2016 18:00 through 3/13/2016 6:00

samhatchett commented 8 years ago

fixed in https://github.com/samhatchett/EPANET/commit/ce7d3f895800355afb9812bb0ceb78ed6fd8cb96