OpenWaterFoundation / owf-app-dev-ng

Open Water Foundation Angular application to develop common libraries
0 stars 1 forks source link

Font Awesome and Material Design Icons are both being used #23

Open Nightsphere opened 2 years ago

Nightsphere commented 2 years ago

There are currently two icon packages being used by the Infomapper/Common library: Font Awesome version 4 and Material Design Icons. It seems a little redundant to have both being used. I feel like one can be removed, as they both contain a good amount of icons, and don't really have something that the other doesn't.

Some red flags I've found with the Material Design Icons package is:

I didn't really see anything inherently wrong with Font Awesome. Version 4 is currently installed, with version 5 being the most current version out, and 6 on the way. As long as the version contains all that the Infomapper needs, staying with version 4 might be okay, but I'll look into upgrading and see what that entails.

Nightsphere commented 2 years ago

I believe npm i @fortawesome/fontawesome-free will download version 6 of font awesome, the latest version out right now. It provides around 1,700 free icons, compared to the 675 that version 4 offers, which is what the Infomapper is currently using. I'm not sure if it's backwards compatible, so I'll have to check that.