Closed Nightsphere closed 2 years ago
A few days after this was created, I found that every part of the code that's using moment as a function was not working anymore. I can't pinpoint exactly broke it, as a newer version of moment hasn't been released for a year. The only change I can think of that might have done it is updating the InfoMapper from Angular version 13.1.3
to 13.2.0
.
To be clear, there are only 3-4 places in the code that uses moment, but each use is for a different component, so as of now, TSGraph and Heatmap Dialogs are no longer working.
I knew it was on its way out already, but I have to upgrade this from a little fix for the future to a multi-feature breaking bug. On top of creating more tests for the Dialogs, this is now the highest priority issue.
A small bug was found before I closed this issue. I squashed it, and added testing so the new date-fns package is covered. Closing this issue.
From Momentjs's own Documentation:
We now generally consider Moment to be a legacy project in maintenance mode. It is not dead, but it is indeed done.
Momentjs was built with the old internet in mind, and never really adapted with the times. Because of this, the project has essentially been abandoned, and will not be supported any longer. They don't recommend creating new projects that use moment. View the docs to peruse a list of other datetime packages that they recommend instead.