search

OpenWaterFoundation / owf-app-infomapper-ng

Open Water Foundation InfoMapper web application for menu-driven maps and visualizations, using Angular
GNU General Public License v3.0
1 stars 2 forks source link

Add Save button to text file popup #265

Open smalers opened 4 years ago

smalers commented 4 years ago

It would be useful to have a Save button on popups to save the content to computer. The following are technical considerations:

  1. The content to be saved should be the original text file, saved with original name and .txt extension. Is the configuration sufficient to pass the original filename and path to the popup so it can be accessed?
  2. Using a Save button at the bottom of the dialog would reinforce a standard layout that includes layout for button(s). A Close button can also be added, similar to other dialogs.
  3. Can Ctrl-s also be supported?
  4. A file chooser should list default filename (the original) and txt extension.
  5. Behavior should be similar to how browser saves the source for web page.
  6. Also need to add a title to text popup if it has not already been done.
smalers commented 3 years ago

My feedback:

  1. I think using a save file that matches the original text file is fine since the display uses the original content.

Let's see how it goes once deployed for users.

smalers commented 3 years ago

The core functionality works. It would still be nice to support Ctrl-s and know how to do a dialog to select local file but that is low priority. I'm changing the priority to medium and keeping open.