search

OpenWaterFoundation / owf-app-infomapper-ng

Open Water Foundation InfoMapper web application for menu-driven maps and visualizations, using Angular
GNU General Public License v3.0
1 stars 2 forks source link

Change popup configuration to use downloadFile #306

Closed smalers closed 4 years ago

smalers commented 4 years ago

We changed the use of save to download but the popup configuration still uses saveFile. I recommend changing that to downloadFile to be consistent. I noticed this while updating the InfoMapper documentation to include the latest. This needs to be updated ASAP before deploying some public website updates.

smalers commented 4 years ago

This has been implemented. Close the issue.

smalers commented 4 years ago

I updated the issue. It should be downloadFile. I think this was implemented but it does not seem to work when the value is a file without the .function() modifiers. For example, the following always results in the download file defaulting to timeseries.csv:

"downloadFile" : "${featureAttribute:StateModStationId}-Available_Flow.csv"
Nightsphere commented 4 years ago

The push for this has been merged, and has been working. Closing the issue.